My favorite teachers are usually Shakespeare geeks or old enough to be my father...or both. Heck, they sometimes remind me of my father from time to time if they're older. Usually in persona or ability to fill my head with historical knowledge. If I have a WWII question, I sometimes turn to my dad.
I had a substitute professor for the first day of one of my college classes who reminded me of one of the best teachers I ever had, who had to leave to become an assistant principal at a school that needed his guidance more than my school did. He was something of a teacher for college prep and occasionally gave us lectures on Shakespeare. And they were bloody awesome. Sometimes it was for speech or critical thinking or history. I'm considering taking that professor's intro to sociology class.
I guess he was the one who gave me a greater appreciation for it. So, when we read Othello in my Senior year, we'd already discussed it in that prep class as Freshmen. And I could think "Behold, Iago, the other of the big SOBs besides Richard III"!
But yeah...if you want to be a teacher I like, you have to blow my mind with critical thinking and psychology/sociology, Shakespeare/literature, be like my dad, or all of them.